thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library
MIT License
329 stars 242 forks source link

PHP 7.0 compatibility - tag a new release? #189

Closed acasar closed 6 years ago

acasar commented 6 years ago

@barryvdh could you tag a new release that includes this commit? https://github.com/thephpleague/omnipay-common/commit/13c909bebcc8da95cad743f09cbdb3fed62b2c19

I have a few projects in production that are still running on PHP 7.0 and can't update composer.

    - omnipay/common v3.0.2 requires php-http/client-implementation ^1 -> no matching package found.
    - omnipay/common v3.0.1 requires php-http/client-implementation ^1 -> no matching package found.
    - omnipay/common v3.0.0 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.3 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.1 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.4 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.3 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.1 requires php-http/client-implementation ^1 -> no matching package found.
    - omnipay/common v3.0-RC2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-RC1 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common 3.0.x-dev requires php-http/client-implementation ^1 -> no matching package found.
    - remove omnipay/braintree 2.0.x-dev|keep omnipay/braintree dev-master
    - omnipay/braintree dev-master requires omnipay/common ^3 -> satisfiable by omnipay/common[3.0.x-dev, v3.0-RC1, v3.0-RC2, v3.0-alpha.1, v3.0-alpha.2, v3.0-alpha.3, v3.0-alpha.4, v3.0-beta.1, v3.0-beta.2, v3.0-beta.3, v3.0.0, v3.0.1, v3.0.2].
    - Installation request for omnipay/braintree ~2.0 -> satisfiable by omnipay/braintree[2.0.x-dev].

Thanks!

barryvdh commented 6 years ago

You need a php-http/client-implementation. See the readme here: https://omnipay.thephpleague.com/installation/

acasar commented 6 years ago

@barryvdh yeah that solves the first issue, but not the second (the reason I opened this ticket):

    - omnipay/common v3.0.0 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.3 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-beta.1 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.4 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.3 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-alpha.2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
    - omnipay/common v3.0-RC2 requires php ^7.1 -> your PHP version (7.0.21) does not satisfy that requirement.
...

Tagging a new release would fix this problem since PHP requirement has been updated here https://github.com/thephpleague/omnipay-common/commit/13c909bebcc8da95cad743f09cbdb3fed62b2c19

barryvdh commented 6 years ago

That is already tagged. Wat version of braintree are you requiring?

acasar commented 6 years ago

I'm actually requiring this package: https://github.com/responsiv/pay-plugin

Which then requires:

        "omnipay/paypal": "~2.0",
        "omnipay/braintree": "~2.0",
        "omnipay/stripe": "~2.0",
barryvdh commented 6 years ago

Yeah that's not gonna work with v3. Raise an issue there.

acasar commented 6 years ago

ok thanks!