search

thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library
MIT License
329 stars 242 forks source link

Add supportsFetchTransaction, fetchTransaction, and acceptNotification methods #190

Closed nicoSWD closed 6 years ago

nicoSWD commented 6 years ago

Hi!

AbstractGateway has a supportsAcceptNotification() method, but acceptNotification() is not in the interface as optional method. Not sure if this is on purpose, but I feel like it should be there.

And as far as I can tell, fetchTransaction() is normally used to fetch transaction info, but it's not currently in the interface / AbstractGateway either.

nicoSWD commented 6 years ago

Any thoughts, @barryvdh?

barryvdh commented 6 years ago

Looks good to me. @judgej ?

judgej commented 6 years ago

Looks great :-)

I feel that the whole notification side needs clearing up too. It's a server request, which often carries the same data as the response class, but sometimes doesn't. And sometimes the notification needs a specific response returned to the API - sometimes just a HTTP code, and sometimes a specific payload. The interfaces we have kind of don't quite cover it. I'll try to get some examples together of what I mean (when project time allows!) Edit: I'm rambling again. Just saying, great step forward, but notifications still need some work.