Change client-implementation to client-common.

thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library

MIT License

329 stars 242 forks source link

Change client-implementation to client-common. #200

Closed noud closed 5 years ago

noud commented 6 years ago

Change php-http/client-implementation to php-http/client-common because that package changed it's name.

This will solve issue: composer missing dep: php-http/client-implementation ^1 #197

And composer is again able to install omnipay-common again.

Would you please be so kind to accept this pull request?

Thanks, Noud

clash82 commented 5 years ago

Can someone review and merge this, pls? I got the same issue.

judgej commented 5 years ago

@barryvdh I think you may be the guy for this one. As it stands, it all works for me, so I really don't understand the problem. Not saying there isn't a problem - just don't understand it.

Is this a production (non-dev) only issue?

barryvdh commented 5 years ago

You're just missing a client implementation. This is a virtual package. See the readme

noud commented 5 years ago

aha, readme: http://docs.php-http.org/en/latest/clients.html

barryvdh commented 5 years ago

See http://omnipay.thephpleague.com/installation/