search

thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library
MIT License
331 stars 245 forks source link

Add getUserMessage() to the response object #23

Closed eileenmcnaughton closed 8 years ago

eileenmcnaughton commented 9 years ago

This allows for situations where the displayable message might differ from the raw message or the processor returns more than one type of message e.g 'failed transaction' for user & 'fraudster alert' for the admin

eileenmcnaughton commented 9 years ago

22 https://github.com/thephpleague/omnipay-common/pull/22

judgej commented 8 years ago

PAYONE has a return field called customerMessage. It is translated to the spoken language that has been requested for the API, and is safe to put in front of end users. I can see this happening for more gateways over time.

delatbabel commented 8 years ago

OK so any objections to me merging this?

delatbabel commented 8 years ago

By "this" I specifically mean PR #22

delatbabel commented 8 years ago

OK I can see it got closed. Please ignore. I will close the issue and if someone wants to raise it again then they can. Otherwise maybe it can be a v3.0 target.

eileenmcnaughton commented 8 years ago

I can't seem to re-open it myself

delatbabel commented 8 years ago

If it's a PR and it's been closed, it can't be re-opened. You will have to submit it again. I can reopen the issue if you want.

eileenmcnaughton commented 8 years ago

Hmm - I brought the PR back to life but it was failing tests - pretty sure it was not adding the fn to the right place so let's leave it

delatbabel commented 8 years ago

Noted, thanks for your efforts anyway.