search

thephpleague / omnipay-common

Core components for the Omnipay PHP payment processing library
MIT License
329 stars 242 forks source link

Release that supports PHP 8 #246

Closed ejunker closed 3 years ago

ejunker commented 3 years ago

I see that master has updated composer.json to support PHP 8. But the latest version at the moment 3.0.5 does not support PHP 8. Please tag a new release so that it has PHP 8 support.

toooni commented 3 years ago

@barryvdh Is there a chance a new release will be dropped soon? As I see it phpro/grumphp must be bumped to ^1.0 to support PHP8. For this to happen we need to have this merged as well: https://github.com/thephpleague/omnipay-tests/pull/16

alexw23 commented 3 years ago

Any update on this one? Will a release soon be tagged?

emielmolenaar commented 3 years ago

This would be great.

emielmolenaar commented 3 years ago

https://github.com/thephpleague/omnipay/releases/tag/v3.2.0 🥳

barryvdh commented 3 years ago

Yes it's tagged. I've removed Grumphp and had to bump the test suite to PHPUnit 9 (with typehints and removal of deprecated things), so also dropped PHP 7.2. But that's not supported anymore anyway.

alexw23 commented 3 years ago

This is awesome, thanks @barryvdh 🎉

I suppose we also need to wait for each individual driver (omnipay-stripe etc) to bump up?

barryvdh commented 3 years ago

Yeah but you can make a PR by bumping the PHP version in composer, the github actions matrix and update the testsuite to use omnipay/tests v4 instead of v3.

emielmolenaar commented 3 years ago

Yeah but you can make a PR by bumping the PHP version in composer, the github actions matrix and update the testsuite to use omnipay/tests v4 instead of v3.

Thanks! I am creating a PR for omnipay-mollie. Did I miss something, or is version 4 of omnipay/tests not tagged yet?

barryvdh commented 3 years ago

Correct, is was dev only. But it's tagged now