search

thephpleague / omnipay-dummy

Dummy driver for the Omnipay PHP payment processing library
MIT License
26 stars 16 forks source link

Implement all standard functions listed in GatewayInterface #5

Closed jtgrimes closed 7 years ago

jtgrimes commented 7 years ago

I found myself needing to add void() and capture() functions so I could test my project, and then it sort of took off. \Omnipay\Common\GatewayInterface lists functions which should be standard in any gateway, so I just implemented a dummy version of all of them.

barryvdh commented 7 years ago

Makes sense to me. If we would really want to complete, we should also allow for a redirect response probably though.

delatbabel commented 7 years ago

Noted, I have a massive backlog of real world work at the moment, will try to clear my github/omnipay backlog early next week.

coatesap commented 7 years ago

+1 Having the refund method on Dummy will be super-useful!

delatbabel commented 7 years ago

@coatesap comment about the docblocks is correct -- these need to be fixed.

Also I see that some parts of the markup in the class docblock have changed, e.g. the headings removed. I see no good reason for that.

delatbabel commented 7 years ago

OK notwithstanding the fact that travis is passing the tests, this PR needs the docblocks fixed before I can merge.

kynx commented 7 years ago

@delatbabel The GatewayInterface says the methods return a RequestInterface.

@jtgrimes I'd really like to see this merged. You OK with me doing a new PR based on this with the docblocks fixed?

jtgrimes commented 7 years ago

@kynx - you bet! I'm sorry I lost track of this PR - if you want to pick it up, that's great!

rquadling commented 6 years ago

@jtgrimes Is your fork at https://github.com/jtgrimes/omnipay-dummy now redundant? Can we move back to using https://github.com/thephpleague/omnipay-dummy? (I think so, just would like to confirm).

jtgrimes commented 6 years ago

@rquadling yep - it was merged in and my fork is actually behind the current repo - definitely switch back.