Closed benileo closed 8 years ago
Good catch Ben, interestingly the test for this function expects false:
$this->assertFalse($response->isSuccessful());
The gateway logic is that since no transaction took place, TransactionStatus
is false.
However I agree this means that isSuccessful
here gives unexpected results. The solution may be to create a RapidDirectCreateCardResponse class which overrides isSuccessful
with criteria along the lines of what you're using. Or I'm open to other ideas!
The solution may be to create a RapidDirectCreateCardResponse class which overrides isSuccessful with criteria along the lines of what you're using.
That sounds the most logical suggestion to me. If someone submits a PR then I will merge it.
See https://go.eway.io/s/question/0D5w000001jr3DjCAI?language=en_US
Perhaps check the response code instead for createCard? Instead of:
I had to implement my own isSuccessful() for this particular gateway (which doesn't seem right)