search

thephpleague / omnipay-eway

eWay driver for the Omnipay PHP payment processing library
MIT License
13 stars 17 forks source link

Shared token requests #21

Closed fryiee closed 7 years ago

fryiee commented 7 years ago

Added Requests for both CreateCard and UpdateCard through RapidShared (roughly mimicking the functionality in RapidDirect). I have not added any response requests as you can utilise the completePurchase() method to finalise both of them all the same. Let me know if you would prefer these as separate responses.

incarnate commented 7 years ago

Thanks for the PR, looks good!

Only change you might want to consider is extending RapidSharedPurchaseRequest for the two requests to cut down on code duplication - just override getData. See RapidDirectCreateCardRequest as an example

fryiee commented 7 years ago

I have just pushed up another commit which makes them extend rather than duplicate code. Thanks!

incarnate commented 7 years ago

Much neater, thanks! @delatbabel please consider for merging

fryiee commented 7 years ago

Is this likely to be merged? I just need to know if I need to attach my fork to my composer package instead of the mainline gateway as I need to roll out this module this week.

incarnate commented 7 years ago

This should be fine to be merged, however since omnipay is an open source project the maintainers are all volunteers and things don't always happen quickly.

If you need to release this week I'd say roll with your own fork and you can update to official once the merge has happened.

delatbabel commented 7 years ago

Hi, yes I saw the ping and I have looked at the code briefly. It should be OK to merge, but I need to have a deeper read and I have a backlog of paying job tasks at the moment. So I'll try to get this done in the next few days.

fryiee commented 7 years ago

No problems guys, fully understand and thanks for your responses. I'm running from my fork for now.

delatbabel commented 7 years ago

OK merged, thanks. Sorry for the delay and thanks for your patience. If you can confirm that this works in a production environment then I will tag for release.

fryiee commented 7 years ago

@delatbabel I never responded to this. I've been using my fork in production for a little while now.

fryiee commented 6 years ago

Hi @delatbabel I'm working on another project that is in need of this. Do you know if it's possible to get this tagged for release? At the moment we're going to run our tagged fork but it would be nice to use the mainline package.

delatbabel commented 6 years ago

Released as 2.2.2

fryiee commented 6 years ago

@delatbabel thanks a bunch!