search

thephpleague / omnipay-eway

eWay driver for the Omnipay PHP payment processing library
MIT License
13 stars 17 forks source link

Add auth to Rapid requests #28

Closed incarnate closed 5 years ago

incarnate commented 6 years ago

During the v3 update authentication was removed from the requests, breaking the library. See issue #27 (this PR does not solve the fact an authentication failure doesn't return an error).

incarnate commented 5 years ago

@barryvdh @delatbabel Hi all, can we look at merging this in, this gateway is non-functional with the authentication broken.

barryvdh commented 5 years ago

Ah yes, the setAuth() doesn't seem to have been ported in https://github.com/thephpleague/omnipay-eway/pull/26

barryvdh commented 5 years ago

It also looks like this can all be in a base request class, but that's for future enhancements.

incarnate commented 5 years ago

Thanks @barryvdh - can you push a new version?

I did end up duplicating the code a lot, certainly needs a refactor but didn't want to complicate this fix.

digitalbridge commented 5 years ago

Hi @barryvdh, experience the same issue here, can you release a new tag?

barryvdh commented 5 years ago

Tagged