search

thephpleague / omnipay-example

Example application for Omnipay PHP payments library
MIT License
100 stars 50 forks source link

Only works on a root path of a domain #3

Closed judgej closed 8 years ago

judgej commented 10 years ago

To get this to work in a sub-directory/virtual folder of a domain, I needed to hack the templates and a couple of the routes. There will be a more generic solution that will work across different paths so it can be installed easily anywhere to try it out.

Unless I am missing a setting somewhere, does it make sense that it should be able to work in non-root paths of a domain?

danhunsaker commented 9 years ago

Given that it's only an example, it seems that's an exercise best left to the reader, as it were. This is far from a great way to process actual payments.

judgej commented 9 years ago

True, but if I'm trying out OmniPay to see how it works, I don't want to have to become an expert in Silex first, just to debug it to get it working in a folder on a dev machine. It's just another hurdle to jump over.

danhunsaker commented 9 years ago

Given the ubiquity and ease of setting up VMs, this isn't likely to be a priority.

Not strictly disagreeing with you on this one; it would be nice if every project on the face of the planet were built with relative paths so things could be run wherever's best with minimum fuss, but alas, the majority of projects assume they'll be alone on a server (and for stability/security purposes that's often wise), so the default mode of thinking is absolute paths.

If this were anything but an example, it would be a no-brainer to accept a PR that made paths relative.

judgej commented 8 years ago

This got fixed a long time ago on PR #4

Not sure how I missed closing this issue. Closing now.