search

thephpleague / omnipay-gocardless

GoCardless driver for the Omnipay PHP payment processing library
MIT License
14 stars 7 forks source link

Signature method should remove unused keys #2

Closed johnnye closed 9 years ago

johnnye commented 9 years ago

The signature method generates invalid signatures if you have a data value that is not used.

One way around this is to wrap all optional parameters in ifs or to strip out the unused values in the signature.

I'll happily look at this in the next few days and propose a patch.

johnnye commented 9 years ago

We're using exactly the same signing method as the official library. I'm now unsure this is a bug. I'll close the ticket and open it again if there are other issues that I can track down.