search

thephpleague / omnipay-migs

MIGS driver for the Omnipay PHP payment processing library
MIT License
21 stars 30 forks source link

Correction in calculateHash() #8

Closed jacobcat closed 8 years ago

jacobcat commented 8 years ago

With the latest version of the MIGS driver, I could not successfully make a payment, due to an Incorrect Hash error that I'm receiving from Omnipay when returning from a completed order.

Upon checking the docs, I found out that there's something missing in the calculateHash() method. The vpc_SecureHash and vpc_SecureHashType parameters should NOT be included in the hash, as indicated in the revised MIGS documentation and sample PHP codes.

On my end, with the proposed changes, I could now complete my order.

barryvdh commented 8 years ago

Is this already fixed with #7?

delatbabel commented 8 years ago

Can you re-test this issue against v2.2.1 which has #7 merged in. I believe that it's the correct fix for this problem.

jacobcat commented 8 years ago

Sorry, I wasn't able to check #7; I was still using v2.2.0 when I last checked, and didn't try to update first.

Discarding this pull request. Thanks.