search

thephpleague / omnipay-mollie

Mollie driver for the Omnipay PHP payment processing library
MIT License
62 stars 38 forks source link

Fix incompatible override of `getRedirectData()` in `FetchTransactionResponse` #90

Open nfourtythree opened 1 year ago

nfourtythree commented 1 year ago

Currently FetchTransactionResponse is redeclaring the getRedirectData() method and always returning null.

This return type does not match the documented and implemented return in Omnipay Common's AbstractResponse

See here: https://github.com/thephpleague/omnipay-common/blob/master/src/Common/Message/AbstractResponse.php#L179-L187

This PR fixes the issue by removing the redeclaration of the method in the class as the inherited implementation does everything that is required.