search

thephpleague / omnipay-multisafepay

MultiSafepay driver for the Omnipay PHP payment processing library
MIT License
19 stars 22 forks source link

Upgrade to Omnipay v3 #28

Closed ruudk closed 6 years ago

barryvdh commented 6 years ago

Thanks! can you also update travis.yml to make sure the tests are working? See https://github.com/thephpleague/omnipay-mollie/blob/master/.travis.yml for an example.

ruudk commented 6 years ago

@barryvdh Wow, you're fast ;) It worked locally, so will update out the travis.yml file!

ruudk commented 6 years ago

@barryvdh Any idea how to solve this issue? It looks like Mockery doesn't work nicely with PHP 5.6 (🤮)

barryvdh commented 6 years ago

Yeah see https://omnipay.thephpleague.com/changelog/ about Testing changes

You should remove the Mockery\Adapter\Phpunit\TestListener in phpunit.xml.dist

ruudk commented 6 years ago

I tested it with iDEAL on the test platform and it all seems to work.

I see that the XmlGateway is deprecated... I think it's better if we remove that deprecation in a further release to ease migrating to Omnipay V3.

So my proposal is:

WDYT?

barryvdh commented 6 years ago

Yeah we can remove it in the feature, or when it's not supported at all. Perhaps we need to add a notice to the readme that it's deprecated.