Authorised express payment `isSuccessful()` always returns `false

thephpleague / omnipay-paypal

PayPal driver for the Omnipay PHP payment processing library

MIT License

295 stars 174 forks source link

Authorised express payment `isSuccessful()` always returns `false #223

Open shopblocks opened 5 years ago

shopblocks commented 5 years ago

The isSuccessful() method always returns false for PayPal_Express. It would be better if this returned whether or not the ACK returned from PayPal is "Success" so that this package is the same as others.

I have made a PR #222 with a change for this but the tests fail due to them expecting false.