Closed judgej closed 6 years ago
Merging into master
to get this into the main branch for pre-release trial. Nothing here should be a BC break, and we still support PHP 5.6 (no matter how much I would have loved to use the null coalescing operator). This will be made a minor release though, just in case the merging of the notification response into the notification request has some unforeseen issues, so the minor release will be a hreads-up. Also the removal of ServerCompleteAuthorize
could bite some sites that have not moved over to acceptNotification
(only acceptNotification
has been maintained for some time).
Started as issue 105 only, which led to some refactoring for a proper fix. Then a bit more refactoring to remove some duplication mainly. Some features:
relatedTransactionReference
as its source, rather than the multiplerelated*
setters as before. The previous setter methods are deprecated, but still work. The documentation reflects the newer way of working with repeat transactions.ServerComplete*
messages removed; useacceptNotification
only for the server-to-server back-channel. The olderServerComplete*
classes contained duplicate code that was getting a bit out of date as it was hard to keep it in sync withacceptNotification
.acceptNotificationResponse
has been merged into theacceptNotificationRequest
class. The new class has the combined features of both.Shared
/Server
/Direct
namespaces. This could then leave room to merge in the newPi
gateway and perhaps some of the Reporting and Admin API features.