thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library
MIT License
54 stars 78 forks source link

Issue105 + refactoring #106

Closed judgej closed 6 years ago

judgej commented 6 years ago

Started as issue 105 only, which led to some refactoring for a proper fix. Then a bit more refactoring to remove some duplication mainly. Some features:

judgej commented 6 years ago

Merging into master to get this into the main branch for pre-release trial. Nothing here should be a BC break, and we still support PHP 5.6 (no matter how much I would have loved to use the null coalescing operator). This will be made a minor release though, just in case the merging of the notification response into the notification request has some unforeseen issues, so the minor release will be a hreads-up. Also the removal of ServerCompleteAuthorize could bite some sites that have not moved over to acceptNotification (only acceptNotification has been maintained for some time).