search

thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library
MIT License
55 stars 78 forks source link

Fix preg_match search on NULL #179

Closed jamieburchell closed 2 years ago

jamieburchell commented 2 years ago

Fixes https://github.com/thephpleague/omnipay-sagepay/issues/177#issuecomment-1061603591

judgej commented 2 years ago

Additional fixes are needed, and I'll add tests with them. The Sage Pay Server integration does not accept the clientIpAddress as a parameter (the Sage Pay Direct integration does), so this integration should not be referencing getClientIp() in the first place. The deprecation warning highlighted that it was referencing the client IP address.

Merging without tests as very clear what this fixes, but will add one with later commits.