search

thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library
MIT License
54 stars 78 forks source link

Copied jamieburchell-opayo-urls into new 3.x branch #200

Closed Ferrisbane closed 5 months ago

Ferrisbane commented 5 months ago

Hi,

Thank you for creating the new 3.x branch.

I've copied over the new Opayo URLs from jamieburchell's branch. I have however left out some ?? '' fallbacks they added, just as these will break people using really out of date PHP versions. Making sure to keep this inline with the 3.x branch and its min requirements.

I've ran the unit tests, they all pass. I've also ran tests on sandbox environments and its now using the new URLs and getting a success response back :).

judgej commented 5 months ago

Thank you. Could you update the readme to explain what this branch is, and mention that it probably won't be maintained (though won't be removed) and to move to a master for the protocol 4.x release when possible.

[!WARNING]
It could be added near the top like this.

Ferrisbane commented 5 months ago

Thanks @judgej. I should have remembered to updated the readme!

I've updated that now, hopefully is now updated in this PR. If you don't like the look I can change no worries.

judgej commented 5 months ago

Merged in now, thank you. This will be useful to some legacy sites. Appologies for the delay - just busy on far too many things.