Add XMLBasket discounts

thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library

MIT License

54 stars 78 forks source link

Add XMLBasket discounts #48

Closed dignat closed 8 years ago

dignat commented 8 years ago

Hello, We needed for our project xml basket discounts implementation of SagePay, but unfortunately it loks like there is a bug in XMLBasket discounts display on the SagePay admin myacount and we could not see the discounts. Here is our little change to XML basket discounts and hopefully SagePay will fix the bug soon. Please can you merge the changes so we could pull and update our omnipay-sagepay driver

judgej commented 8 years ago

Are you closing this because you no longer need it?

dignat commented 8 years ago

No I realized I have opened two pull requests for basketXML, that's why i closed this one ,and left only one.

judgej commented 8 years ago

Ah, right. I saw two closed PRs when I looked at what was closed, and didn't spot that there was a third one still open.