search

thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library
MIT License
55 stars 78 forks source link

XMLBasket with discounts #50

Closed dignat closed 8 years ago

dignat commented 8 years ago

Hello , we need XML basket with discounts for our project, could you please check the fork and merge it to master

judgej commented 8 years ago

First change on the AbstractRequest:

use Omnipay\BarclaysEpdq\Item

I assume that's left in from some experiments?

I haven't tried this yet, but wondering how the non-XML basket gets disabled, i.e. excluded from the data sent (unless I'm just imagining this gateway driver ever did support the old CSV basket)?

dignat commented 8 years ago

Hello Jason, Thank you for reply and that you are looking into the fork. I had tested we do get the basket with the items but unfortunately not the discounts. we have contacted to Sage pay support and they confirmed that the xml we are sending is correct, but the discounts can not be displayed. here is what we see on sagePay admin site: sagepayadmin

coatesap commented 8 years ago

+1 This feature will be very useful to have released

judgej commented 8 years ago

@coatesap I agree, I'll give it a test with a few other scenarios and merge it in. While this driver supported SagePay 2.0, the XML basket needed to be optional. Now everyone is on Sage Pay 3.0, the XML basket will be available to everyone, so should be used by default.

dignat commented 8 years ago

Hi Jason, Yes it makes sense to check thsi->getItemData(). I will changed it. Cheers

judgej commented 8 years ago

If the basket is not set at all, then an empty <basket /> element is created, and Sage Pay reports this as an invalid basket format. The basket either needs to have one or more items in, or it should be omitted completely.

I'm not sure the easiest way to fix this wrt the PR. I assume I can create my own PR, pull yours into it, then push the combined fix.

judgej commented 8 years ago

I've extended this with PR #51