search

thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library
MIT License
54 stars 78 forks source link

XMLBasket with discounts (extension of PR #50) #51

Closed judgej closed 8 years ago

judgej commented 8 years ago

I've fixed an empty basket issue in PR #50 and added some tests.

judgej commented 8 years ago

Just had a thought - probably needs some tests for negative item prices, to show them appearing as discounts. I'll try and get those in before creating a release.

dignat commented 8 years ago

Thank you so much. This is brilliant. I appreciate it. Thank you once again Denise

coatesap commented 8 years ago

Hi @judgej - any chance of a version bump so we can start using this via composer?

judgej commented 8 years ago

Not sure if this should be a patch release (2.2.1) or a point release (2.3.0). It is just new functionality, so should not affect people not using it. However, there could be systems that are passing the basket in anyway, not expecting it to actually work.

I vote for 2.3.0 - it's not as though we are going to run out of version numbers quickly. It just highlights that functionality may change without the merchant site doing anything differently. Agree?

coatesap commented 8 years ago

Agreed - 2.3.0 makes most sense as it should count as additional functionality.