search

thephpleague / omnipay-sagepay

Sage Pay driver for the Omnipay PHP payment processing library
MIT License
55 stars 78 forks source link

Fixes #61 Support for SagePay token system #62

Closed ntsim closed 8 years ago

ntsim commented 8 years ago

Fixes #61.

Includes support for both Direct and Server integration pathways. This has mostly been recycled directly from a project that I used this on so it should be working, but would probably need some extra eyes to make sure that it works when integrated with production code (and not just unit tests).

judgej commented 8 years ago

Had a play with this, and it looks great. I'll try to get it merged today. Some later PRs I have will have merge conflicts with this, so I'll get it done in this order.

The ServerCompleteAuthorizeRequest is being deprecated for a ServerNotifyRequest class that handles incoming server requests (the Complete methods were really only designed to handle data the end user comes back with, rather then back-end server notifications). It is going to be interesting merging them, since the way the signature is built depends on the exact message that is being sent.

I'm also renaming some of the classes that lack the "Direct" prefix so it is more easily identified as to which group it belongs to. So TokenRemovalRequest will likely be renamed to DirectTokenRemovalRequest - any Direct or Shared APIs that are strictly server-to-server are being put under the Direct group - maybe you have some thoughts on that.