search

thephpleague / omnipay-stripe

Stripe driver for the Omnipay PHP payment processing library
MIT License
184 stars 167 forks source link

Intents authorize will behave the same as a purchase by default #232

Open jamieburchell opened 7 months ago

jamieburchell commented 7 months ago

Removing $data['capture_method'] = 'manual' here changes this method to behave the same as a purchase by default and not an authorization. The authorization method is supposed to require a manual capture as per the class comments:

 * An authorize request is similar to a purchase request but the
 * charge issues an authorization (or pre-authorization), and no money
 * is transferred.  The transaction will need to be captured later
 * in order to effect payment. Uncaptured charges expire in 7 days.
jamieburchell commented 7 months ago

Attn: @barryvdh I believe this is a breaking change that by default will change the nature of the authorize method to become a regular payment method instead.

barryvdh commented 7 months ago

Yeah so do you have a PR to fix it?

jamieburchell commented 7 months ago

Yeah so do you have a PR to fix it?

No. I just spotted this when trying to make sense of the readme vs code comments vs actual code and thought it was a serious issue.

I don't think it makes sense to allow the capture_method to be set at all. Authorization request == manual, payment request == automatic?