search

thephpleague / omnipay-targetpay

TargetPay driver for the Omnipay PHP payment processing library
MIT License
14 stars 4 forks source link

Get transactionReference from current request #2

Closed barryvdh closed 10 years ago

barryvdh commented 10 years ago

Instead of transactionId, because trxid is the transactionReference instead of transactionId, in Omnipay context. Fixes #1

aderuwe commented 10 years ago

:+1:

amacneil commented 10 years ago

Looks good. FYI in future you can simply push additional commits, or force push new commits to your existing branch to update a PR.

amacneil commented 10 years ago

Speaking of which, can you squash these changes to a single commit and force push? Otherwise I'll merge this when I'm back at my computer.

barryvdh commented 10 years ago

Yeah I tried doing that, I sent another commit to patch-1, but it didn't get picked up by the PR. Perhaps because it was already closed. But I squashed the commits, hope this is better.

amacneil commented 10 years ago

:+1: thanks

barryvdh commented 10 years ago

Thanks :) Can you also tag a new release?

amacneil commented 10 years ago

Done :)