Upgrade for PHPUnit 8/9

thephpleague / omnipay-tests

Test components for the Omnipay PHP payment processing library

MIT License

10 stars 35 forks source link

Upgrade for PHPUnit 8/9 #16

Closed frankverhoeven closed 3 years ago

frankverhoeven commented 4 years ago

This PR will upgrade the package to support PHPUnit ^8.0 || ^9.0.

Note that this change is not backwards compatible, because lower versions of PHPUnit are no longer supported. Reason being that assertInternalType has been deprecated/removed and replaced by specific assertions like assertIsString. Moreover, the minimal PHP version has been increased to 7.2, because that is the lowest version supported by PHPUnit 8.0.

barryvdh commented 3 years ago

Are these changes still required? I would rather not add return types to all functions, unless required. I sadly missed this before updating/tagging a new version with phpunit 9. The common test suite seemed to be working though.

barryvdh commented 3 years ago

Overall these changes are good, but I think a bit too much:

$this-> vs self:: -> matter of preference according to https://phpunit.readthedocs.io/en/9.5/assertions.html#static-vs-non-static-usage-of-assertion-methods
return types to all methods -> can be good but is more work to change for gateway developers
Phpunit 8: Is not supported anymore so I dropped it, together with 7.2

barryvdh commented 3 years ago

InternalType is fixed: https://github.com/thephpleague/omnipay-tests/commit/5c8eb1499bcd5a35d53d11f3424faa78ead5251d