search

thephpleague / omnipay

A framework agnostic, multi-gateway payment processing library for PHP 5.6+
http://omnipay.thephpleague.com/
MIT License
5.91k stars 925 forks source link

Installation does not work using PHP 8 #637

Closed pierreminiggio closed 3 years ago

pierreminiggio commented 3 years ago

Hello. I can't install omnipay on PHP 8. image

Tried setting my omnipay dependency to the dev-master branch as I noticed PHP 8 support is supposed to be handled by this PR that got merged on master : https://github.com/thephpleague/omnipay/pull/625

But as you see it does not work, because the omnipay/common dependency's version stated in omnipay composer only supports PHP7.

I can still use the ignore-platform-reqs flag of composer to install it, But gotta say I don't like doing that :'(

pierreminiggio commented 3 years ago

I'm having a similar issue with omnipay-stripe : https://github.com/thephpleague/omnipay-stripe/issues/198

Ocramius commented 3 years ago

This is expected: mostly need a release to be tagged, but otherwise dev-master is already capable of being installed with PHP 8

bbashy commented 3 years ago

Been tagged by the looks of it.

barryvdh commented 3 years ago

Yes it's tagged 🎉

pierreminiggio commented 3 years ago

Hello ! Thanks, I'm confirming that it now works on my PHP8 project without needing to use the ignore-platform-reqs option.