search

thephpleague / route

Fast PSR-7 based routing and dispatch component including PSR-15 middleware, built on top of FastRoute.
http://route.thephpleague.com
MIT License
651 stars 126 forks source link

Added test for ContainerAwareTrait #220

Closed ricardofiorani closed 5 years ago

philipobenito commented 5 years ago

Please take note of the coding standards and tools already used in this library. Even tests require docblocks and we do not currently use prophesize.

ricardofiorani commented 5 years ago

@philipobenito prophesize comes with phpunit now so I thought it was ok to use. Please let me know which strategy for mocking objects is preferable.

philipobenito commented 5 years ago

I know but the rest of the tests currently use the normal phpunit mocking framework so I’d rather keep consistency for now

Sent from my iPhone

On 17 Jan 2019, at 16:43, Ricardo Fiorani notifications@github.com wrote:

@philipobenito prophesize comes with phpunit now so I thought it was ok to use. Please let me know which strategy for mocking objects is preferable.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

philipobenito commented 5 years ago

Closing as stale and no response