thephpleague / route

Fast PSR-7 based routing and dispatch component including PSR-15 middleware, built on top of FastRoute.
http://route.thephpleague.com
MIT License
651 stars 126 forks source link

Fix psr/simple-cache version constraint. Fixes #320 #321

Open arabcoders opened 2 years ago

arabcoders commented 2 years ago

Widen psr/simple-cache version constraint to support 1.0|2.0|3.0. Fixes #320

philipobenito commented 2 years ago

Sorry for the delay on this, will be merging and tagging early next week.

philipobenito commented 2 years ago

This actually causes an issue on PHP 8 as there is a method signature change

arabcoders commented 2 years ago

This actually causes an issue on PHP 8 as there is a method signature change

Hmm.. im using this in my composer.json

{
    "require": {
        "psr/simple-cache": "3.0 as 1.0",
    }
}

and not getting any errors from router or anything and i have error_reporting set to E_ALL and running PHP 8.1

sneakyvv commented 2 years ago

What was the error? The logs for the tests have been removed already :\

arabcoders commented 2 years ago

What was the error? The logs for the tests have been removed already :\

locking dependency on 1.0 causes conflicts as a lot of packages have moved on to 3.0

sneakyvv commented 2 years ago

So what's the plan for this @philipobenito, can't these other dependencies be updated/upgraded as well?

sneakyvv commented 1 year ago

This actually causes an issue on PHP 8 as there is a method signature change

@philipobenito, sorry to push for this again, but can you elaborate, so we can move away from the 7-year old dependency?

sneakyvv commented 1 year ago

@philipobenito I investigated it myself, and understand the issue now. To be able to fix this, support for PHP7 needs to be dropped, which is what #327 is about.

sneakyvv commented 1 year ago

No takers?

philipobenito commented 1 year ago

Dealing with health issues, will get to it as soon as I can

Sent from Proton Mail for iOS

On Thu, Jan 26, 2023 at 07:42, Bart Vanderstukken @.***> wrote:

No takers?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

sneakyvv commented 1 year ago

Oh sorry to hear that, take care!

sneakyvv commented 1 year ago

@philipobenito did you have a change to look at this?

rikgirbes commented 1 year ago

any updates to this?

philipobenito commented 3 weeks ago

Handled this locally for 6.x release, I know it's been promised before, but coming early next week