search

thephpleague / statsd

A library for working with StatsD
MIT License
351 stars 56 forks source link

`throwConnectionExceptions` wasn't getting passed through service providers to Laravel et al #26

Closed richardbenson closed 8 years ago

richardbenson commented 8 years ago

As a follow up to #25 I noticed that no matter what throwConnectionExceptions was set to, Laravel still threw one, so this fixed that.

Specifically to Laravel, the trigger_error call will stop execution, meaning even with throwConnectionExceptions switched off, any issue sending the packet will still trigger a full shutdown of the framework.

I'm not sure how best to adjust this behaviour without affecting non Laravel users.