search

thephpleague / statsd

A library for working with StatsD
MIT License
351 stars 56 forks source link

Updated Silex to ~2.0. #43

Closed carl-boisvert closed 7 years ago

carl-boisvert commented 7 years ago

Silex 2 has been release last year and there was some changes that this library doesn't support.

I don't know if there's a particular reason as why it wasn't updated, but I'm proposing this pull request to update the Silex version to ~2.0.

The ServiceProviderInterface has change namespace in version ~2.0. It's now: use Pimple\ServiceProviderInterface;

Updated the StatsdServiceProvider to reflect that change

marcqualie commented 7 years ago

Hey @carl-boisvert thanks for the contribution.

I'm not familiar with Silex 2.0 myself so I can technically verify this, but if this patch works for your app then that should be fine.

One thing I noticed was the tests now fail due to old PHP version requirements. I've updated master to test against the currently supported versions, could you please rebase your branch against that so the tests run?

Thanks

carl-boisvert commented 7 years ago

Here we go, rebase done and doc updated!

Thanks for the feedback!

marcqualie commented 7 years ago

Thanks @carl-boisvert