search

thephpleague / statsd

A library for working with StatsD
MIT License
351 stars 56 forks source link

Update codestyle, php version, tests, add interface #59

Closed Jeroeny closed 2 years ago

Jeroeny commented 2 years ago

This library hasn't been updated in a while. I'm not sure if that's intentional, but I've taken an attempt to modernize this library a bit. I hope an update for this library can be considered. If this is not the right approach of some changes should be left out / split in other PRs, let me know.

I've added an interface, which would be nice to have for dependency injection and mocking in tests. Updated PHPUnit and the tests. Used the last maintained PHP version as minimum and used types where possible. Applied the PSR codestyle. Added GitHub actions configuration.

Jeroeny commented 2 years ago

@marcqualie would you be willing to take a look?

xvilo commented 2 years ago

This PR looks good to me 👍

Jeroeny commented 2 years ago

@colinodell I think this can be merged now?

colinodell commented 2 years ago

I'll get it merged sometime this week (possibly this weekend). I'd also like to review the other outstanding PRs and see if we can include them too :)

colinodell commented 2 years ago

Version 2.0.0 has been released! Thanks so much for your help with this :)