thephpleague / tactician-bernard

Tactician integration with the Bernard queueing library
MIT License
19 stars 3 forks source link

New name instead of BernardQueueing #1

Closed sagikazarmark closed 9 years ago

sagikazarmark commented 9 years ago

Ideas plz, this name gave me cancer.

rosstuck commented 9 years ago

Just League\Tactician\Bernard then? We're probably going to have other Queuing packages in the future so calling it League\Tactician\Queuing might be a bit too broad.

sagikazarmark commented 9 years ago

That might be better. I know there was arguments against it, because Bernard is too vague, but it is not the package name that should give the description, is it?

sagikazarmark commented 9 years ago

@rosstuck Is tactician-bernard and League\Tactician\Bernard fine for you?

rosstuck commented 9 years ago

Works for me! We can document the queueing aspect in the manual.

sagikazarmark commented 9 years ago

OK, let's leave it after the PR gets merge to make sure we don't get lost in some composer configuration madness.

sagikazarmark commented 9 years ago

@rosstuck as soon as the middleware architecture is finished I am going to open a PR which does every in-repo modifications to be able to rename it to tactician-bernard. After that the following should be done:

I am assigning this to you @rosstuck and asking you to do what needs to be done when the time comes. :sunglasses:

rosstuck commented 9 years ago

Aight, can do. :)

sagikazarmark commented 9 years ago

@rosstuck see #10

rosstuck commented 9 years ago

Okay, should be done. Scrutinizer is showing NaN for code coverage but I'm going to assume that's a temporary issue for now.

sagikazarmark commented 9 years ago

Yeah, it should be temporary. If you review/merge the docs PR, I am going to tag v0.1.

sagikazarmark commented 9 years ago

Thanks