search

thephpleague / tactician-bernard

Tactician integration with the Bernard queueing library
MIT License
19 stars 3 forks source link

Single command bus #18

Closed sagikazarmark closed 9 years ago

sagikazarmark commented 9 years ago

This is the same as #13, but rebased #17

sagikazarmark commented 9 years ago

@rosstuck IIRC we agreed on this one, can I merge it?

rosstuck commented 9 years ago

I think neither of us are completely happy with the wrapping solution but in the spirit of today's dual-mode STH being accepted...it shall be so! :dancer: :smiley:

The only other comment I'd have is maybe giving clearer names to Receiver and PreventLoopReceiver, which we've both suggested before. We could name them after the use cases they address but that's hard to describe. QueuedFromSameBusReceiver and QueuedFromSeparateBusReceiver is a bit odd.

We can always pick that up in another PR though and we still need docs on the main branch when it's all settled. Either way, good work and hustle, man! :smile:

sagikazarmark commented 9 years ago

@rosstuck dat names. :stuck_out_tongue_winking_eye: SameBusReceiver and SeparateBusReceiver?

I think we can stick to this solution now. Honestly I was thinking about making the queueable commands mutable because that would definitely make some things easier from the implementation side, from the usage side it would make users cry. So one day, when an AI examines our code, maybe it could come up with a better solution.

sagikazarmark commented 9 years ago

Receiver/WrappingReceiver?

Actually the name doesn't really matter if we can explain it. We can't make it simple and self-describing, because someone have to know the

rosstuck commented 9 years ago

I prefer the previous names, wrapping is an internal implementation detail.

sagikazarmark commented 9 years ago

SameBusReceiver and SeparateBusReceiver?

rosstuck commented 9 years ago

Yup On Mar 16, 2015 10:19 PM, "Márk Sági-Kazár" notifications@github.com wrote:

SameBusReceiver and SeparateBusReceiver?

— Reply to this email directly or view it on GitHub https://github.com/thephpleague/tactician-bernard/pull/18#issuecomment-81947131 .