search

thephpleague / tactician-bernard

Tactician integration with the Bernard queueing library
MIT License
19 stars 3 forks source link

Improvements #33

Closed sagikazarmark closed 7 years ago

rosstuck commented 8 years ago

Same feedback as https://github.com/thephpleague/tactician-command-events/pull/17

Also, on an unrelated note (perhaps better to discuss on IRC later this week): I'm not super involved in this project really and feel like I'm mostly a barrier. Furthermore, it's a bit reliant on the current state of Bernard in terms of stability. How would you feel about spinning it off from the League into your namespace where you can have full control over it again?

sagikazarmark commented 8 years ago

Removed CoC from here as well.

Honestly, I would not be too happy to move this package around. Mainly because I don't have the time right now, but also because I think it is better to keep these stuff together. The reason why this plugin is not ready yet is that bernard isn't. My OSS time mostly goes to HTTPlug and FXMLRPC nowadays.

After that if you still think this should get out of the League, we can talk about it. But apart from my disagreement, the lack of time is what really blocking it right now.

sagikazarmark commented 7 years ago

Closed in favor of #43 with better separation.