search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Test against PHP 7.3+ and Symfony 4.0+ #109

Closed PabloKowalczyk closed 5 years ago

PabloKowalczyk commented 5 years ago

This PR add new test cases to CI, this will cover new versions of PHP and Symfony. As a bonus there is a fix for Symfony deprecation in 4.2, fixed same way as in https://github.com/doctrine/DoctrineBundle/pull/853.

BTW Symfony 3.3 is not supported anymore, maybe it is time to drop support for it?

rosstuck commented 5 years ago

Thanks a ton, I think you've made a lot of folks quite happy :)

rosstuck commented 5 years ago

Re: support, I'm also evaluating dropping support for older versions of PHP for a bunch of the packages soon so will probably make another pass for Symfony compat as well. Would also like to drop Symfony 2.8 support as well since it's in security fix only mode but not sure yet.

PabloKowalczyk commented 5 years ago

@rosstuck let's continue discussion here https://github.com/thephpleague/tactician-bundle/issues/110.