search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Fixed configuration definition #39

Closed RonRademaker closed 7 years ago

RonRademaker commented 7 years ago

This PR closes #36

I tested this in a symfony setup where I also merged #33 into my test setup. Everything seems to work fine.

rosstuck commented 7 years ago

Nice catch! I wonder if we could get an integration tests to catch these sorts of things somehow...

tyx commented 7 years ago

Be aware that I introduced integration tests into #33 :D

rosstuck commented 7 years ago

Haha yeah, sorry, I was referring to that jokingly. :)

If we can get some of these optional features tested in the same way, that would drastically reduce the need for manual verification and we can go ahead there.

In my latest excuse, I'm laid up with the flu but I'm loving the energy here. 👍