search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Remove some unnecessary mocks #48

Closed chalasr closed 7 years ago

rosstuck commented 7 years ago

Definitely a step forward, thanks a ton!

rosstuck commented 7 years ago

By the by, any reason to not use the Noback test extensions for these? Not a blocking complaint, etc, just curious if they didn't work. 😄

chalasr commented 7 years ago

They would surely have worked well, the reason is that I personally prefer to not rely on any third party extension in tests. Like this, understanding these tests doesn't require to know more than phpunit, that can make contributing easier. I'm not against these extensions, but I think we should avoid them as possible in distributed bundles/libs test suites, keeping them simple.