search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Reduced voter complexity #50

Closed RonRademaker closed 7 years ago

RonRademaker commented 7 years ago

The dependency is pointless because all roles are already in the supplied $token.

jvasseur commented 7 years ago

Doesn't this break when using a role hierarchy ?

RonRademaker commented 7 years ago

Good point, role hierarchy would be unsupported in this setup. Do we consider that a problem?

chalasr commented 7 years ago

Not worth losing it to me

rosstuck commented 7 years ago

Agreed, role hierarchy is pretty commonly used in projects I've worked on in the past. I'd rather keep support for it.

RonRademaker commented 7 years ago

I've added role hierarchy support 👍

RonRademaker commented 7 years ago

After some more consideration and reading up on things, I agree we should use the access decision manager. Closing this PR.