search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Make CommandHandlerPass using the real merged config #82

Closed tyx closed 7 years ago

tyx commented 7 years ago

Problem Because container->getExtensionConfig() does not return merged config.

Solution Use a temporary dic parameter to transport the merged config to the CommandHandlerPass.

Fix #80

rosstuck commented 7 years ago

Thanks for the fix! I'll tag a 1.1.1 for this after looking at the other PRs.

I do feel this is a weakness in Symfony's setup but as the least bad solution it works. :) (That's no disrespect to you @tyx, you rock for picking this up!)