search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Allow Symfony 4 #85

Closed ogizanagi closed 7 years ago

ogizanagi commented 7 years ago

This is the continuation of #77 which dropped unmaintained versions of Symfony and aimed to support Symfony 4 too (#78 was closed in favor of it), but constraints for sf 4.0 are actually missing from the patch.

tyx commented 7 years ago

ahah nice catch :sunglasses:

ogizanagi commented 7 years ago

Failure on 4.0 build is normal, as matthiasnoback/symfony-config-test does not allow sf 4.0 yet, so enforcing installing 4.0 for every component fails for now. But as you can see through other builds, everything runs fine with symfony 4: https://travis-ci.org/thephpleague/tactician-bundle/jobs/300183759#L517-L538

rosstuck commented 7 years ago

Thanks, nicely done! :)