thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Fix test suite errors on symfony4 #91

Closed rosstuck closed 6 years ago

rosstuck commented 6 years ago

Noticed this started kicking in once Symfony4 was released. This isn't really elegant but it's the best I've got off the top of my head.

Any thoughts, @chalasr?

rosstuck commented 6 years ago

Also started updating Travis config https://github.com/thephpleague/tactician-bundle/commit/13785c4e84171c35d8585c22a50eeabe54fd3f1f

rosstuck commented 6 years ago

If there are no objections, I'll merge this tonight and tag a new release.

tyx commented 6 years ago

It's fine for me to make command bus public :+1:

chalasr commented 6 years ago

Same 👍 Sorry for the late answer.

rosstuck commented 6 years ago

No worries, I appreciate you both taking the time! ❤️