search

thephpleague / tactician-bundle

Bundle to integrate Tactician with Symfony projects
MIT License
245 stars 43 forks source link

Symfony 3.3+ support #96

Closed adiq closed 6 years ago

adiq commented 6 years ago

As mentioned in #95: In newer Symfony versions, services are private by default. Beside of that, the naming convention of services has been changed to use FQCN to provide compatibility with the new autowiring feature.

Services should be renamed to use FQCN and be private. To have backward compatibility aliases should be added and marked as public.

See https://symfony.com/doc/current/service_container/3.3-di-changes.html#step-2-using-class-service-id-s for details

ogizanagi commented 6 years ago

the naming convention of services has been changed to use FQCN

Actually the naming convention hasn't changed for third-party bundles. But we can expose FQCN (or Interface FQCN aliases to real services) for service we want to be autowirable. Hence, only a few services should be aliased.

rosstuck commented 6 years ago

Hi @adiq,

Thanks for opening this issue and using tactician! Do please try to keep issues to one topic at a time and not mention them across multiple issues.

As I see it, this privacy topic is being discussed in #95 (which I've reopened). Let's keep talking about it there.

Adding an alias or similar for FQCN is an interesting idea, but is not unique to issues under 3.4, so please open a separate ticket if you'd still like to discuss it. Sorry to sound like a stickler about this but it really helps keep things organized. :)