search

thephpleague / tactician-container

Load Tactician handlers from any PSR-11/container-interop container
MIT License
75 stars 8 forks source link

Container locator #2

Closed NigelGreenway closed 9 years ago

NigelGreenway commented 9 years ago

Initial container locator plugin code

rosstuck commented 9 years ago

Added a couple comments. If you can resolve these, I see no reason to not merge. :+1:

NigelGreenway commented 9 years ago

Hi @rosstuck,

Done the changes as suggested.

Hope thats better ;)

rosstuck commented 9 years ago

Looking good! Thanks a ton for all your work and patience on this. :smile:

I'm gonna merge ASAP but not tag a release yet, since I'm running around and sending PRs to all the different repos in preparation for the command interface being removed ( https://github.com/thephpleague/tactician/issues/43 ). I'll do that later today and wait for your feedback on that PR before merging as well.

Once again, many thanks! :smile: