search

thephpleague / tactician-doctrine

Tactician plugins for the Doctrine ORM, primarily transactions
MIT License
57 stars 13 forks source link

Use Throwable and fixed throws annotation #10

Closed GrahamCampbell closed 8 years ago

GrahamCampbell commented 8 years ago

This is the best for forwards compatibility. Anything that's throwable needs catching. There's no reason to assume Exception and Error are the only base cases to implement Throwable.

rosstuck commented 8 years ago

Makes sense. We can knock out the Exception block when we go 7 or higher :)

Now that I think about it, one thing the original PR was missing was a test for this path. Would you mind adding one?

GrahamCampbell commented 8 years ago

Done. :)

boekkooi commented 8 years ago

@GrahamCampbell @rosstuck :+1: I'm totally ok with this thanks for adding the test.

rosstuck commented 8 years ago

Done. I've readded the throws annotation for the PHP 5.x person, just to be cautious. Thanks to both of you!