Closed GrahamCampbell closed 8 years ago
Makes sense. We can knock out the Exception block when we go 7 or higher :)
Now that I think about it, one thing the original PR was missing was a test for this path. Would you mind adding one?
Done. :)
@GrahamCampbell @rosstuck :+1: I'm totally ok with this thanks for adding the test.
Done. I've readded the throws annotation for the PHP 5.x person, just to be cautious. Thanks to both of you!
This is the best for forwards compatibility. Anything that's throwable needs catching. There's no reason to assume Exception and Error are the only base cases to implement Throwable.