calvera commented 3 years ago

@rosstuck can you make a release please?

simPod commented 3 years ago

Yay!

snapshotpl commented 2 years ago

@rosstuck what about release?

rosstuck commented 2 years ago

So, here's the crappy part. There's two issues here:

This PR allowed DBAL v3 into master, which is all the unreleased Tactician 2 stuff. Tagging a release off master will just break more stuff. To get a release for Tactician 1, I've made a branch on this repo called tactician-v1 but that branch is sold that to get the testsuite running on PHP8, it needs at least a PHPUnit upgrade. Can you try to send a similar PR there with the extra tweaks?
Furthermore, this PR (even for the newer Tactician 2 stuff) broke the build because DBAL v3 apparently doesn't have a ping() method anymore and this repo has a PingConnectionMiddleware. Therefore, we need to make that test conditional or at least more clever. I've switched it from Travis to Github Actions to help with that at least.

simPod commented 2 years ago

@rosstuck can we bump min php version on v1? I went to upgrade phpunit there but it's php v5.5+ and I kind of don't want to work with that. 🤔

snapshotpl commented 2 years ago

snapshotpl commented 2 years ago

28 resolves second issue

snapshotpl commented 2 years ago

For first I think we should drop unsupported PHP versions.

snapshotpl commented 2 years ago

@simPod @rosstuck done in #29

thephpleague / tactician-doctrine