search

thephpleague / tactician-logger

Adds PSR-3 logging support to the Tactician Command Bus
62 stars 8 forks source link

Rename command completed to command executed #1

Closed sagikazarmark closed 9 years ago

sagikazarmark commented 9 years ago

Just a minority to be consistent with CommandExecuted event.

rosstuck commented 9 years ago

Gonna sleep on this one. I actually forgot about the Event being named that and considered a couple variations here and went with Completed since it doesn't confused anyone with being the first action in the sequence nor in the case of a queue do we know if was actually executed, just that our part in it finished (I'm aware that Completed could be construed the same way).

Will ponder tonight and probably tweak tomorrow. :)

rosstuck commented 9 years ago

If we wanted to be completely consistent everywhere, maybe we should rename both to CommandHandled, since the method is now called handle()? Neither package has a ton of downloads yet so it shouldn't be a hugely disruptive change.

sagikazarmark commented 9 years ago

Agreed.

rosstuck commented 9 years ago

All good here and first logger release tagged! Hope this helps. :)

sagikazarmark commented 9 years ago

:+1: