search

thephpleague / tactician-logger

Adds PSR-3 logging support to the Tactician Command Bus
62 stars 8 forks source link

log Context did not used #4

Closed tyx closed 8 years ago

tyx commented 8 years ago

Hey guys.

Is there any good reason do add properties values directly into the message instead of adding them into the log context ? Would be more clean as the serialization would be the monolog responsability. And more reliable to use some stuff like the GelfHandler of monolog

I'm available to make the PR if you are ok.

rosstuck commented 8 years ago

Hi @tyx, thanks for opening this issue!

That sounds pretty reasonable to me. The only part I'm not sure about is how to format all the "extra" parameters into the log message since we don't always know what those will be (depends on the command) but if you've got an idea for it, that sounds pretty cool.

Go for it :+1: