search

theprojectboom / engine

0 stars 0 forks source link

Add GitHub actions for Jupyter notebooks #16

Closed Rio6 closed 2 years ago

Rio6 commented 2 years ago

15

Not tested at all since I don't know how to trigger it on Github. Might need to merge it into master for it to get picked up.

Rio6 commented 2 years ago

oh it runs when I open the PR

Rio6 commented 2 years ago

Fixed CI-related errors, but the actual script still fails. @MrMinos if you can look at the newest ci log and see what's up that'd be great. I'm not familiar with what the scripts are supposed to do.

MrMinos commented 2 years ago

Are you able to see the CI logs? Just checking if there needs to be a permission related thing.

MrMinos commented 2 years ago

It seems like it's checking for the cell output correctly. It is failing as intended.

The current master does not work so it makes sense. If we merge this, and I rebase my branch, we should see the CI succeeding on that branch.

Rio6 commented 2 years ago

yeah we can do that, though we probably need to temporarily un-protect master to merge it. And yes I can see the logs.