search

thepudds / fzgen

Auto-gen Go fuzzing wrappers from normal code. Finds buggy call sequences, including data races & deadlocks. Supports rich signature types.
Apache License 2.0
105 stars 5 forks source link

remove emitted comment about goimports #4

Closed josharian closed 2 years ago

josharian commented 2 years ago

It's easy enough to run goimports programatically (it's exposed as a package, not just an executable), so fzgen should just do it, rather than:

// if needed, fill in imports or run 'goimports'
thepudds commented 2 years ago

Hi @josharian it does already programmatically run imports.Process from the golang.org/x/tools/imports package.

And I have a TODO In the code to remove that noisy comment you are referencing, but I am slightly worried about corner cases, which is why I haven’t removed it yet.

That said, no time like the present.

A general comment is thank you again for taking the time to file these quick issues based on your first impressions… Hopefully it will help smooth things out for others…

thepudds commented 2 years ago

Hi @josharian, I am going to take the liberty of retitling this to be about the effectively misleading or at least not very useful comment.

The comment should be eliminated with PR #16.

Thanks again!