search

theraot / Theraot

Backporting .NET and more: LINQ expressions in .net 2.0 - nuget Theraot.Core available.
MIT License
162 stars 30 forks source link

IAsyncEnumerable<T> is not included in net48 build #197

Open ig-sinicyn opened 1 year ago

ig-sinicyn commented 1 year ago

The IAsyncEnumerable interface is not shipped as a part of net48 (see the "Applies to" section). Theraot.Core does include its own copy but it is excluded for the net48 target, IAsyncEnumerable.cs:

#if LESSTHAN_NET47 || LESSTHAN_NETCOREAPP20 || LESSTHAN_NETSTANDARD20
...

I'm not sure if it was done intentionally, so just a report here:)

OwnageIsMagic commented 1 year ago

This is intentional not including it when targeting net461+ since otherwise it would conflict with Microsoft.Bcl.AsyncInterfaces from other packages as you already found in a hard way. The fix is to replace LESSTHAN_NET47 with LESSTHAN_NET46.

NN--- commented 1 year ago

This is intentional not including it when targeting net461+ since otherwise it would conflict with Microsoft.Bcl.AsyncInterfaces from other packages as you already found in a hard way. The fix is to replace LESSTHAN_NET47 with LESSTHAN_NET46.

Want to open a PR?

OwnageIsMagic commented 1 year ago

It could be done from web editor, but I'm puzzled with current branching policy.

theraot commented 1 year ago

The branches got messy for the attempt to add a version 4 which was allowing unsafe. The idea being that whatever restructuring/splitting can happen in develop_v4, and would be v4 once released... Assuming anything of that were to be done.

The bulk of the work remains in develop_v3, and v3 is the last released.

However there are changes in master which would have to be merged on develop_v3, if they don't break anything. And then possibly if to develop_4, if that will be worked on.

That leaves what to do with master afterwards... It could be kept in sync with either develop_v3 or develop_v4, which ever is to be worked primarily, which would also ease pull request going forward.

NN--- commented 1 year ago

@theraot Can you open discussions page in GitHub ? @OwnageIsMagic I think we should discuss how to move forward. There is a branch messing little bit. There should be one branching policy :)